Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17459#discussion_r109364067
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/IndexedRowMatrix.scala
---
@@ -113,6 +114,67 @@ class IndexedRowMatrix @Since("1.0.0") (
}
/**
+ * Converts to BlockMatrix. Creates blocks of `DenseMatrix` with size
1024 x 1024.
+ */
+ def toBlockMatrixDense(): BlockMatrix = {
--- End diff --
I am not sure if DenseMatrix-backed is better default behavior for
`toBlockMatrix`. Actually the rows in `IndexedRowMatrix` can be sparse or
dense. Choose which one, SparkMatrix-backed or DenseMartix-backed, is totally
depending on the use case.
Looks like `toBlockMatrixDense` is already a non-small function. Merging it
with current `toBlockMatrix` might not a good idea. I'd keep it as it's now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
