Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r109826890
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -386,7 +386,7 @@ class SparkSqlAstBuilder(conf: SQLConf) extends
AstBuilder {
"LOCATION and 'path' in OPTIONS are both used to indicate the
custom table path, " +
"you can only specify one of them.", ctx)
}
- val customLocation = storage.locationUri.orElse(location)
+ val customLocation =
storage.locationUri.orElse(location.map(CatalogUtils.stringToURI(_)))
--- End diff --
Also, it seems we have a similar util with `CatalogUtils.stringToURI` in
`org.apache.spark.util.Utils.resolveURI`. Could we consolidate them? I did not
replace it when I identified this because some existing tests in
`org.apache.spark.util.UtilsSuite` were broken but I guess it would be fine if
there is a coherent reason. These broken cases might be bugs.
@windpiger could you double check my comments and open a followup if I was
not wrong?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
