Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r109827042
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -386,7 +386,7 @@ class SparkSqlAstBuilder(conf: SQLConf) extends
AstBuilder {
"LOCATION and 'path' in OPTIONS are both used to indicate the
custom table path, " +
"you can only specify one of them.", ctx)
}
- val customLocation = storage.locationUri.orElse(location)
+ val customLocation =
storage.locationUri.orElse(location.map(CatalogUtils.stringToURI(_)))
--- End diff --
It seems this has a double-de/encoding problem when the input path is an
URI.
```scala
scala> new org.apache.hadoop.fs.Path(new java.io.File("a
b").toURI.toString).toUri.toString
res1: String = file:/.../a%2520b
```
A space character in URI is encoded as `%20` and `%` character is encoded
as `%25`. A URI already has a %20 in it, and gets urlencoded again, from `%20`
to `%2520`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
