Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14617#discussion_r109830395
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorsPage.scala 
---
    @@ -115,8 +115,9 @@ private[spark] object ExecutorsPage {
         val rddBlocks = status.numBlocks
         val memUsed = status.memUsed
         val maxMem = status.maxMem
    -    val onHeapMemUsed = status.onHeapMemUsed
    -    val offHeapMemUsed = status.offHeapMemUsed
    +    // Only maxOnHeapMem and maxOffHeapMem are defined these two fields 
are not None.
    --- End diff --
    
    I don't understand this comment.  Maybe you mean "status.onHeapMemUsed is 
only valid if maxOnHeapMem is defined"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to