Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14617#discussion_r109830934
  
    --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala ---
    @@ -111,7 +115,11 @@ class RDDDataDistribution private[spark](
         val address: String,
         val memoryUsed: Long,
         val memoryRemaining: Long,
    -    val diskUsed: Long)
    +    val diskUsed: Long,
    +    val onHeapMemoryUsed: Long,
    +    val offHeapMemoryUsed: Long,
    +    val onHeapMemoryRemaining: Long,
    +    val offHeapMemoryRemaining: Long)
    --- End diff --
    
    I don't see any reason why the history server *couldn't* show this info.  
Though we would be fine now by having them be defined without Option, I worry 
that will be a problem if we ever change the history server to show this info, 
since it won't always have it available.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to