Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/17467#discussion_r110437838
--- Diff:
external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisBackedBlockRDD.scala
---
@@ -83,7 +83,8 @@ class KinesisBackedBlockRDD[T: ClassTag](
@transient private val isBlockIdValid: Array[Boolean] = Array.empty,
val retryTimeoutMs: Int = 10000,
val messageHandler: Record => T =
KinesisInputDStream.defaultMessageHandler _,
- val kinesisCreds: SparkAWSCredentials = DefaultCredentials
+ val kinesisCreds: SparkAWSCredentials = DefaultCredentials,
+ val kinesisConf: Map[String, String] = Map.empty
--- End diff --
do you need this to be provided as a `Map`? You already have `sc` being
passed in with all the configurations
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
