Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17541#discussion_r110519122
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -423,8 +423,15 @@ case class CatalogRelation(
Objects.hashCode(tableMeta.identifier, output)
}
- /** Only compare table identifier. */
--- End diff --
Actually we should compare more, e.g. if the table schema is altered, the
new table relation should not be considered as same with the old table
relation, even after canonicalization. Also, it's tricky to remove the output
of a plan during canonicalization as the parenting plan may rely on the output.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
