Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17541#discussion_r110533216
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala
---
@@ -43,17 +43,8 @@ case class LogicalRelation(
com.google.common.base.Objects.hashCode(relation, output)
}
- override def sameResult(otherPlan: LogicalPlan): Boolean = {
- otherPlan.canonicalized match {
- case LogicalRelation(otherRelation, _, _) => relation ==
otherRelation
- case _ => false
- }
- }
-
- // When comparing two LogicalRelations from within
LogicalPlan.sameResult, we only need
- // LogicalRelation.cleanArgs to return Seq(relation), since
expectedOutputAttribute's
- // expId can be different but the relation is still the same.
- override lazy val cleanArgs: Seq[Any] = Seq(relation)
+ // Only care about relation when canonicalizing.
+ override def preCanonicalized: LogicalPlan = copy(catalogTable = None)
--- End diff --
The builders of external data sources need to implement `equals` and
`hashCode` if they want to utilize our cache management.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
