Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17495#discussion_r110721933
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
---
@@ -571,6 +572,34 @@ class FsHistoryProviderSuite extends SparkFunSuite
with BeforeAndAfter with Matc
}
}
+ test("log without read permission should be filtered out before actual
reading") {
+ class TestFsHistoryProvider extends
FsHistoryProvider(createTestConf()) {
--- End diff --
I think you'll need this from another test in this same file:
```
// setReadable(...) does not work on Windows. Please refer JDK-6728842.
assume(!Utils.isWindows)
```
In fact shouldn't this test be merged with the test for SPARK-3697?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
