Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/17495#discussion_r110799889
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
---
@@ -571,6 +572,34 @@ class FsHistoryProviderSuite extends SparkFunSuite
with BeforeAndAfter with Matc
}
}
+ test("log without read permission should be filtered out before actual
reading") {
+ class TestFsHistoryProvider extends
FsHistoryProvider(createTestConf()) {
--- End diff --
The difference of this unit test is that this UT checks whether the file is
filtered out during check, and for SPARK-3697 UT, it only checks the final
result, so file could be filtered out during read. Let me merge this two UTs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
