Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/17436#discussion_r110923167 --- Diff: core/src/main/java/org/apache/spark/memory/MemoryConsumer.java --- @@ -41,7 +41,7 @@ protected MemoryConsumer(TaskMemoryManager taskMemoryManager, long pageSize, Mem } protected MemoryConsumer(TaskMemoryManager taskMemoryManager) { --- End diff -- [This test code](https://github.com/apache/spark/blob/master/core/src/test/java/org/apache/spark/memory/TestMemoryConsumer.java#L24) is only the case that specifies memory mode different from `TaskMemoryManager.getTungstenMemoryMode()`. To simplify the code, I have just replaced `MemoryConsumer(taskMemoryManager, pageSize, taskMemoryManager.getTungstenMemoryMode())` with `MemoryConsumer(taskMemoryManager, pageSize)`.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org