Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r111372491
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java
---
@@ -90,6 +91,8 @@
*/
private ColumnarBatch columnarBatch;
+ private MemoryMode memoryMode = null;
--- End diff --
I agree. IIUC, only [these three test
suites](https://github.com/apache/spark/blob/master/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetEncodingSuite.scala#L37)
requires case 1 without calling `PinitBatch(partitionColumns, partitionValues,
isEnabledOffHeap)`.
If we solve them, we can remove `(memoryMode != null) ?` at line 203.
Case 2 is still required since line 213 calls `initBatch()` after calling
`initBatch(partitionColumns, partitionValues, isEnabledOffHeap)`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
