Github user srowen commented on the issue: https://github.com/apache/spark/pull/17628 I would support this but only if we try to fix all such instances. The val/var changes has some value. However you're also removing 'return' and while that's probably OK as cleanup it's not actually improving much, so am not sure I'd do that.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org