Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17628
Yeah, I'm surprised IntelliJ doesn't have an inspection for it. It's
otherwise quite hard to find instances that can be changed.
I would look for instances of ` var foo = "string"` as these are often
instances where someone meant to declare a constant. There are about 100 of
those. If you scan those and address any issues you see, that's a pretty good
effort.
IntelliJ can find all the `return` instances, and there are 39 of them. I'm
kind of neutral on cleaning that up, but it would be nice. They occur in places
that don't seem likely to cause merge conflicts. Maybe OK to finally touch it
up, OK.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
