Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17568#discussion_r111713040
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/objects.scala
---
@@ -96,3 +98,22 @@ object CombineTypedFilters extends Rule[LogicalPlan] {
}
}
}
+
+/**
+ * Removes MapObjects when the following conditions are satisfied
+ * 1. Mapobject(e) where e is lambdavariable(), which means types for
input output
+ * are primitive types
+ * 2. no custom collection class specified
+ * representation of data item. For example back to back map
operations.
+ */
+object EliminateMapObjects extends Rule[LogicalPlan] {
+ def apply(plan: LogicalPlan): LogicalPlan = plan transform {
+ case DeserializeToObject(Invoke(
+ MapObjects(_, _, _, _ : LambdaVariable, inputData, None),
--- End diff --
can we just replace `MapObjects` with its child? Seems the only reason you
match the whole `DeserializeToObject` is to make sure the `returnType` is
object type, but that's guaranteed if the `collectionClass` is None.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
