Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17568#discussion_r111884257
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
 ---
    @@ -368,6 +369,8 @@ case class NullPropagation(conf: SQLConf) extends 
Rule[LogicalPlan] {
           case EqualNullSafe(Literal(null, _), r) => IsNull(r)
           case EqualNullSafe(l, Literal(null, _)) => IsNull(l)
     
    +      case AssertNotNull(c, _) if !c.nullable => c
    --- End diff --
    
    as long as we trust the `nullable` property, I think it's safe to remove 
it. We don't use `AssertNull` to validate the input data.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to