Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17024#discussion_r111832087
--- Diff: core/src/test/scala/org/apache/spark/CheckpointSuite.scala ---
@@ -266,13 +309,44 @@ class CheckpointSuite extends SparkFunSuite with
RDDCheckpointTester with LocalS
override def sparkContext: SparkContext = sc
runTest("basic checkpointing") { reliableCheckpoint: Boolean =>
- val parCollection = sc.makeRDD(1 to 4)
- val flatMappedRDD = parCollection.flatMap(x => 1 to x)
- checkpoint(flatMappedRDD, reliableCheckpoint)
- assert(flatMappedRDD.dependencies.head.rdd === parCollection)
- val result = flatMappedRDD.collect()
- assert(flatMappedRDD.dependencies.head.rdd != parCollection)
- assert(flatMappedRDD.collect() === result)
+ startSparkContext()
+ testBasicCheckpoint(sc, reliableCheckpoint)
+ }
+
+ runTest("compression with snappy", skipLocalCheckpoint = true) { _:
Boolean =>
--- End diff --
After you change the config to `spark.checkpoint.compress`, you don't need
to test all compression codecs. Just write one test for the default codec.
Others should be covered in `CompressionCodecSuite`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
