Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17024#discussion_r111829941
--- Diff:
core/src/main/scala/org/apache/spark/rdd/ReliableCheckpointRDD.scala ---
@@ -133,9 +136,14 @@ private[spark] object ReliableCheckpointRDD extends
Logging {
val broadcastedConf = sc.broadcast(
new SerializableConfiguration(sc.hadoopConfiguration))
// TODO: This is expensive because it computes the RDD again
unnecessarily (SPARK-8582)
+ val startTime = System.currentTimeMillis()
sc.runJob(originalRDD,
writePartitionToCheckpointFile[T](checkpointDirPath.toString,
broadcastedConf) _)
+ logInfo(s"Checkpointing took ${System.currentTimeMillis() - startTime}
ms.")
+ sc.conf.getOption("spark.checkpoint.compress.codec").foreach(codec => {
--- End diff --
For consistency, I suggest we just add a new config
`spark.checkpoint.compress` which means whether to enable checkpoint
compression. See
https://github.com/apache/spark/blob/b56ad2b1ec19fd60fa9d4926d12244fd3f56aca4/core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala#L74
for example.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
