Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16781#discussion_r111891150
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala
 ---
    @@ -261,18 +266,20 @@ private[parquet] class ParquetRowConverter(
     
           case TimestampType =>
             // TODO Implements `TIMESTAMP_MICROS` once parquet-mr has that.
    +        // If the table has a timezone property, apply the correct 
conversions.  See SPARK-12297.
    +        val sessionTz = 
TimeZone.getTimeZone(hadoopConf.get(SQLConf.SESSION_LOCAL_TIMEZONE.key))
    --- End diff --
    
    Is this safe without checking `null`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to