Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16781#discussion_r111891207
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala
---
@@ -673,12 +681,26 @@ private[parquet] object ParquetRowConverter {
unscaled
}
- def binaryToSQLTimestamp(binary: Binary): SQLTimestamp = {
+ /**
+ * Converts an int96 to a SQLTimestamp, given both the storage timezone
and the local timezone.
+ * The timestamp is really meant to be interpreted as a "floating time",
but since we
+ * actually store it as micros since epoch, why we have to apply a
conversion when timezones
+ * change.
+ * @param binary
+ * @return
+ */
--- End diff --
Can you add `@fromTz`, `@toTz` and descriptions of these?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
