Github user squito commented on the issue:

    https://github.com/apache/spark/pull/17700
  
    Thanks for doing this quickly @jerryshao. I wasn't very clear about this on 
the jira, but my original idea was to add another level of nesting in the json, 
and put all the new memory related metrics under there (leaving `maxmemory` and 
`memoryUsed` as they were for compatibility), eg.:
    
    ```
    {
      "id" : "1",
      "hostPort" : "172.22.0.167:51490",
       ...
      "memoryMetrics": {
        "usedOnHeapStorageMemory": ...,
        "usedOffHeapStorageMemory": ...,
        ...
      }
    }
    ```
    
    I think that organization would be a little more clear.
    
    @tgravescs wdyt?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to