Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/17700#discussion_r112730552
--- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorsPage.scala
---
@@ -114,10 +114,16 @@ private[spark] object ExecutorsPage {
val rddBlocks = status.numBlocks
val memUsed = status.memUsed
val maxMem = status.maxMem
- val onHeapMemUsed = status.onHeapMemUsed
- val offHeapMemUsed = status.offHeapMemUsed
- val maxOnHeapMem = status.maxOnHeapMem
- val maxOffHeapMem = status.maxOffHeapMem
+ val memoryMetrics = for {
+ onHeapUsed <- status.onHeapMemUsed
+ offHeapUsed <- status.offHeapMemUsed
+ maxOnHeap <- status.maxOnHeapMem
+ maxOffHeap <- status.maxOffHeapMem
+ } yield {
+ new MemoryMetrics(onHeapUsed, offHeapUsed, maxOnHeap, maxOffHeap)
--- End diff --
I just want to double check -- there won't be any issues with event logs
from spark 2.1, and only some of these fields being present, right? taking a
quick look at 2.1 and your last change
https://github.com/apache/spark/pull/14617, this looks right.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
