Github user budde commented on a diff in the pull request:
https://github.com/apache/spark/pull/17467#discussion_r112566462
--- Diff:
external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisBackedBlockRDD.scala
---
@@ -147,6 +152,14 @@ class KinesisSequenceRangeIterator(
private var lastSeqNumber: String = null
private var internalIterator: Iterator[Record] = null
+ // variable for kinesis wait time interval between next retry
+ private var kinesisWaitTimeMs = JavaUtils.timeStringAsMs(
--- End diff --
I don't think you want to do this-- ```kinesisWaitTimeMs``` is never reset
to the default value after the retry loop exists. I think you should make this
a ```val``` and introduce a ```var``` initialized to its value within
```retryOrTimeout()``` to store the wait time for each retry iteration.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
