Github user budde commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17467#discussion_r112765111
  
    --- Diff: 
external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisBackedBlockRDD.scala
 ---
    @@ -17,21 +17,24 @@
     
     package org.apache.spark.streaming.kinesis
     
    -import scala.collection.JavaConverters._
    -import scala.reflect.ClassTag
    -import scala.util.control.NonFatal
    -
    -import com.amazonaws.auth.{AWSCredentials, 
DefaultAWSCredentialsProviderChain}
    +import com.amazonaws.auth.AWSCredentials
     import com.amazonaws.services.kinesis.AmazonKinesisClient
     import com.amazonaws.services.kinesis.clientlibrary.types.UserRecord
     import com.amazonaws.services.kinesis.model._
    -
     import org.apache.spark._
     import org.apache.spark.internal.Logging
    +import org.apache.spark.network.util.JavaUtils
     import org.apache.spark.rdd.{BlockRDD, BlockRDDPartition}
     import org.apache.spark.storage.BlockId
     import org.apache.spark.util.NextIterator
     
    +import scala.collection.JavaConverters._
    --- End diff --
    
    Why change the ordering of this import group? I don't think this is 
consistent with the scalastyle for this project.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to