Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112595036
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1005,6 +1005,31 @@ class Analyzer(
}
/**
+ * Replace unresolved expressions in grouping keys with resolved ones in
SELECT clauses.
+ */
+ object ResolveAggAliasInGroupBy extends Rule[LogicalPlan] {
+
+ override def apply(plan: LogicalPlan): LogicalPlan =
plan.resolveOperators {
+ case agg @ Aggregate(groups, aggs, child)
+ if conf.groupByAliases && child.resolved &&
aggs.forall(_.resolved) &&
+ groups.exists(!_.resolved) =>
+ agg.copy(groupingExpressions = groups.map {
+ case u: UnresolvedAttribute =>
+ val resolvedAgg = aggs.find(ne => resolver(ne.name, u.name))
+ // Check if no aggregate function exists in GROUP BY
+ resolvedAgg.foreach {
+ case Alias(e, _) if
ResolveAggregateFunctions.containsAggregate(e) =>
+ throw new AnalysisException(
+ s"Aggregate function `$e` is not allowed in GROUP BY")
--- End diff --
okay, I'll update soon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
