Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r113599279
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -998,6 +998,22 @@ class Analyzer(
}
/**
+ * Replace unresolved expressions in grouping keys with resolved ones in
SELECT clauses.
+ */
+ object ResolveAggAliasInGroupBy extends Rule[LogicalPlan] {
+
+ override def apply(plan: LogicalPlan): LogicalPlan =
plan.resolveOperators {
+ case agg @ Aggregate(groups, aggs, child)
+ if conf.groupByAliases && child.resolved &&
aggs.forall(_.resolved) &&
--- End diff --
I'm not very confident about this condition, we may mistakenly resolve
grouping expression by aggregate list while it should be resolved by child
output.
one example is the star. If the aggregate list contains a star, then we
will expand the star in `ResolveReferences`, without resolving grouping
expressions. When we reach here, the condition will match but the grouping
expression should not be resolved by aggregate list.
cc @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
