Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17711#discussion_r112628499
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -547,6 +547,10 @@ valueExpression
| left=valueExpression comparisonOperator right=valueExpression
#comparison
;
+builtinOpExpression
+ : primaryExpression (CONCAT_PIPE primaryExpression)*
#concat
--- End diff --
Should we move this to the head of the primaryExpression rule? That seems
easier.
I am also trying to figure how this works with other binary operators, for
example: `a + b || c`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
