Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17711#discussion_r112652461
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -547,6 +547,10 @@ valueExpression
| left=valueExpression comparisonOperator right=valueExpression
#comparison
;
+builtinOpExpression
+ : primaryExpression (CONCAT_PIPE primaryExpression)*
#concat
--- End diff --
If we do you suggested, we need to write a rule like `primaryExpression
(CONCAT_PIPE primaryExpression)+ ` to avoid left-recursive. But, IIUC this rule
parses `a || b || c` into Concat(a, Concat(b, c))`. So, I fixed in the current
way from the suggestion of @viirya.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
