Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2366#discussion_r17829919
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -787,31 +789,88 @@ private[spark] class BlockManager(
}
/**
+ * Get peer block managers in the system.
+ */
+ private def getPeers(forceFetch: Boolean): HashSet[BlockManagerId] = {
+ val cachedPeersTtl = conf.getInt("spark.storage.cachedPeersTtl", 60 *
1000) // milliseconds
+ val timeout = System.currentTimeMillis - lastPeerFetchTime >
cachedPeersTtl
+
+ cachedPeers.synchronized {
--- End diff --
you should also do the timeout check in the synchronized block - because
otherwise two racing requests will immediately send two requests to the driver,
and the requests are kind of expensive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
