Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2366#discussion_r17831655
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -787,31 +789,88 @@ private[spark] class BlockManager(
}
/**
+ * Get peer block managers in the system.
+ */
+ private def getPeers(forceFetch: Boolean): HashSet[BlockManagerId] = {
--- End diff --
`updatePeersFromMaster` is a misnomer as it does not actually query master
until the parameter is true or the TTL has expired (which I have increased to
60 seconds). MOST of the time it is a cheap operation. So I am not sure whats
best here.
I am totally open to more suggestions. How about keeping it `getPeers` with
param name as `forceUpdateFromMaster`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
