Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17649#discussion_r112824647
  
    --- Diff: 
sql/core/src/test/resources/sql-tests/results/describe-table-after-alter-table.sql.out
 ---
    @@ -0,0 +1,162 @@
    +-- Automatically generated by SQLQueryTestSuite
    +-- Number of queries: 12
    +
    +
    +-- !query 0
    +CREATE TABLE table_with_comment (a STRING, b INT, c STRING, d STRING) 
USING parquet COMMENT 'table_comment'
    +-- !query 0 schema
    +struct<>
    +-- !query 0 output
    +
    +
    +
    +-- !query 1
    +DESC formatted table_with_comment
    +-- !query 1 schema
    +struct<col_name:string,data_type:string,comment:string>
    +-- !query 1 output
    +# col_name                 data_type               comment             
    +a                          string                                      
    +b                          int                                         
    +c                          string                                      
    +d                          string                                      
    +                                                                       
    +# Detailed Table Information                                               
    
    +Database                   default                                     
    +Table                      table_with_comment                          
    +Created [not included in comparison]
    +Last Access [not included in comparison]
    +Type                       MANAGED                                     
    +Provider                   parquet                                     
    +Comment                    table_comment                               
    +Location [not included in 
comparison]sql/core/spark-warehouse/table_with_comment
    +
    +
    +-- !query 2
    +ALTER TABLE table_with_comment set tblproperties(comment = "modified 
comment")
    +-- !query 2 schema
    +struct<>
    +-- !query 2 output
    +
    +
    +
    +-- !query 3
    +DESC formatted table_with_comment
    +-- !query 3 schema
    +struct<col_name:string,data_type:string,comment:string>
    +-- !query 3 output
    +# col_name                 data_type               comment             
    +a                          string                                      
    +b                          int                                         
    +c                          string                                      
    +d                          string                                      
    +                                                                       
    +# Detailed Table Information                                               
    
    +Database                   default                                     
    +Table                      table_with_comment                          
    +Created [not included in comparison]
    +Last Access [not included in comparison]
    +Type                       MANAGED                                     
    +Provider                   parquet                                     
    +Comment                    modified comment                            
    +Properties                 [comment=modified comment]                      
    
    --- End diff --
    
    We should remove `comment` from `Properties `


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to