Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17700#discussion_r112879836
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorsPage.scala 
---
    @@ -114,10 +114,16 @@ private[spark] object ExecutorsPage {
         val rddBlocks = status.numBlocks
         val memUsed = status.memUsed
         val maxMem = status.maxMem
    -    val onHeapMemUsed = status.onHeapMemUsed
    -    val offHeapMemUsed = status.offHeapMemUsed
    -    val maxOnHeapMem = status.maxOnHeapMem
    -    val maxOffHeapMem = status.maxOffHeapMem
    +    val memoryMetrics = for {
    +      onHeapUsed <- status.onHeapMemUsed
    +      offHeapUsed <- status.offHeapMemUsed
    +      maxOnHeap <- status.maxOnHeapMem
    +      maxOffHeap <- status.maxOffHeapMem
    +    } yield {
    +      new MemoryMetrics(onHeapUsed, offHeapUsed, maxOnHeap, maxOffHeap)
    --- End diff --
    
    Yes, this is to make sure `memoryMetrics` field will only be existed when 
replaying new event logs, for Spark 2.1- event log, this field will not be 
present.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to