Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17556#discussion_r114134468
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -1009,10 +1009,24 @@ private[spark] object RandomForest extends Logging {
// sort distinct values
val valueCounts = valueCountMap.toSeq.sortBy(_._1).toArray
- // if possible splits is not enough or just enough, just return all
possible splits
+ // perhaps weighted mean is better in the future, see SPARK-16957
and Github PR 17556.
+ def mean(pre: (Double, Int), cur: (Double, Int)): Double = {
+ val (preValue, preCount) = pre
--- End diff --
Yeah, we should get rid of this method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
