Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17556#discussion_r114457816
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -1037,7 +1042,8 @@ private[spark] object RandomForest extends Logging {
// makes the gap between currentCount and targetCount smaller,
// previous value is a split threshold.
if (previousGap < currentGap) {
- splitsBuilder += valueCounts(index - 1)._1
+ // perhaps weighted mean will be used later, see SPARK-16957
and Github PR 17556.
--- End diff --
Comments like these tend to just get left around and sit there forever.
Unless we file a _new_ JIRA that intends to decide on future behavior, I would
like to remove this comment altogether. Otherwise, no one will follow up on
this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
