Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17885#discussion_r115137816
--- Diff: dev/create-release/release-build.sh ---
@@ -163,9 +163,9 @@ if [[ "$1" == "package" ]]; then
export ZINC_PORT=$ZINC_PORT
echo "Creating distribution: $NAME ($FLAGS)"
- # Write out the NAME and VERSION to PySpark version info we rewrite
the - into a . and SNAPSHOT
- # to dev0 to be closer to PEP440. We use the NAME as a "local version".
- PYSPARK_VERSION=`echo "$SPARK_VERSION+$NAME" | sed -r "s/-/./" | sed
-r "s/SNAPSHOT/dev0/"`
+ # Write out the VERSION to PySpark version info we rewrite the - into
a . and SNAPSHOT
+ # to dev0 to be closer to PEP440.
+ PYSPARK_VERSION=`echo "$SPARK_VERSION" | sed -r "s/-/./" | sed -r
"s/SNAPSHOT/dev0/"`
--- End diff --
This also affects the `pyspark-*.tgz` artifact name. It seems like this
means the same file name will be used for different flavors of the release. If
they're identical anyway it's just redundant, but are they? I don't know this
part well so might be misunderstanding what this would do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
