Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2464#discussion_r17934308
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/StreamingContextSuite.scala
---
@@ -293,3 +300,37 @@ class TestReceiver extends
Receiver[Int](StorageLevel.MEMORY_ONLY) with Logging
object TestReceiver {
val counter = new AtomicInteger(1)
}
+
+/** Streaming application for testing DStream and RDD creation sites */
+package object testPackage extends Assertions {
--- End diff --
This is a package so that I can exclude
`org.apache.spark.streaming.testPackage` in the filter function to
`Utils.getCallSite()` and treat this package as a user-code for testing. Also,
I was following the strategy used for testing Spark core call site in
[`SparkContextInfoSuite`](https://github.com/tdas/spark/blob/master/core/src/test/scala/org/apache/spark/SparkContextInfoSuite.scala#L75).
Regarding naming strategy, besides the example in `SparkContextInfoSuite`,
the official [Scala style
guide](http://docs.scala-lang.org/style/naming-conventions.html) says
1. *Objects follow the class naming convention (camelCase with a capital
first letter) except when attempting to mimic a package or a function.*
2. *Scala packages should follow the Java package naming conventions*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
