Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2464#discussion_r17935069
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -859,18 +864,27 @@ private[spark] object Utils extends Logging {
}
}
- /**
- * A regular expression to match classes of the "core" Spark API that we
want to skip when
- * finding the call site of a method.
- */
- private val SPARK_CLASS_REGEX =
"""^org\.apache\.spark(\.api\.java)?(\.util)?(\.rdd)?\.[A-Z]""".r
+ /** Default filtering function for finding call sites using
`getCallSite`. */
+ private def defaultCallSiteFilterFunc(className: String): Boolean = {
--- End diff --
This is what I argued in the other thread. Its does just check whether it
is spark class or not. It also ignores Scala classes. So `isSparkCoreClass` is
kind-of wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
