Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17770#discussion_r115408432
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -47,36 +47,11 @@ abstract class LogicalPlan extends
QueryPlan[LogicalPlan] with Logging {
def isStreaming: Boolean = children.exists(_.isStreaming == true)
/**
- * Returns a copy of this node where `rule` has been recursively applied
first to all of its
- * children and then itself (post-order). When `rule` does not apply to
a given node, it is left
- * unchanged. This function is similar to `transformUp`, but skips
sub-trees that have already
- * been marked as analyzed.
- *
- * @param rule the function use to transform this nodes children
- */
- def resolveOperators(rule: PartialFunction[LogicalPlan, LogicalPlan]):
LogicalPlan = {
- if (!analyzed) {
- val afterRuleOnChildren = mapChildren(_.resolveOperators(rule))
- if (this fastEquals afterRuleOnChildren) {
- CurrentOrigin.withOrigin(origin) {
- rule.applyOrElse(this, identity[LogicalPlan])
- }
- } else {
- CurrentOrigin.withOrigin(origin) {
- rule.applyOrElse(afterRuleOnChildren, identity[LogicalPlan])
- }
- }
- } else {
- this
- }
- }
-
- /**
* Recursively transforms the expressions of a tree, skipping nodes that
have already
* been analyzed.
*/
def resolveExpressions(r: PartialFunction[Expression, Expression]):
LogicalPlan = {
--- End diff --
this should also be removed, we should use `transformExpressions`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
