Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/17910#discussion_r115451397
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -526,7 +526,7 @@ class LogisticRegression @Since("1.2.0") (
case None => histogram.length
}
- val isMultinomial = $(family) match {
+ val isMultinomial = $(family).toLowerCase(Locale.ROOT) match {
--- End diff --
+1 @zhengruifeng. I'd like to put the original value in param, since users
may compare the param value with the original input as following:
```
val family = "Binomial"
val lr = new LogisticRegression().setFamily(family)
val model = lr.fit(dataset)
...
if (family == lr.getFamily)
println("A")
else
println("B")
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
