Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17910#discussion_r115813053
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -2318,8 +2319,8 @@ class LogisticRegressionSuite
assert(m1.interceptVector ~== m2.interceptVector absTol 0.05)
}
val testParams = Seq(
- ("binomial", smallBinaryDataset, 2),
- ("multinomial", smallMultinomialDataset, 3)
+ ("Binomial", smallBinaryDataset, 2),
--- End diff --
What about "binomial" and "BiNoMiaL"? Also, what about doing:
````scala
lr.setFamily("BiNomial")
assert(lr.getFamily === "binomial")
````
Also, I'm not a big fan of sprinkling these very subtle "tests" around the
test suite. We should have dedicated tests of this functionality. Otherwise,
how should future developers know that the capital "B" here is supposed to be
there and is actually testing some desired functionality?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
