Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17934#discussion_r115695253
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -146,7 +146,7 @@ object StringIndexer extends
DefaultParamsReadable[StringIndexer] {
* This is a temporary fix for the case when target labels do not exist
during prediction.
*/
@Since("1.4.0")
-class StringIndexerModel (
+class StringIndexerModel private[ml] (
--- End diff --
Hmm, making this private now will break user code if it is used, no? It's
unfortunate that it wasn't private before, but do we want to do this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
