Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/17934#discussion_r115766342
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -146,7 +146,7 @@ object StringIndexer extends
DefaultParamsReadable[StringIndexer] {
* This is a temporary fix for the case when target labels do not exist
during prediction.
*/
@Since("1.4.0")
-class StringIndexerModel (
+class StringIndexerModel private[ml] (
--- End diff --
We make this public by mistake, so I think we should fix this bug. AFAIK,
this is the only model whose constructor is public, so there is little chance
to break user code. And I think it makes sense to break user code by fixing
bug. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
