Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17958#discussion_r116288183
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala
 ---
    @@ -202,13 +203,22 @@ private[state] class HDFSBackedStateStoreProvider(
         /** Abort all the updates made on this store. This store will not be 
usable any more. */
         override def abort(): Unit = {
           verify(state == UPDATING || state == ABORTED, "Cannot abort after 
already committed")
    +      try {
    +        state = ABORTED
    +        if (tempDeltaFileStream != null) {
    +          tempDeltaFileStream.close()
    +        }
    +        if (tempDeltaFile != null) {
    +          fs.delete(tempDeltaFile, true)
    +        }
    +      } catch {
    +        case c: ClosedChannelException =>
    --- End diff --
    
    Why need two `case`s? The error message is same, and the exception is also 
in the log.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to