Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17958#discussion_r116289648
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala
 ---
    @@ -202,13 +203,22 @@ private[state] class HDFSBackedStateStoreProvider(
         /** Abort all the updates made on this store. This store will not be 
usable any more. */
         override def abort(): Unit = {
           verify(state == UPDATING || state == ABORTED, "Cannot abort after 
already committed")
    +      try {
    +        state = ABORTED
    +        if (tempDeltaFileStream != null) {
    +          tempDeltaFileStream.close()
    +        }
    +        if (tempDeltaFile != null) {
    +          fs.delete(tempDeltaFile, true)
    +        }
    +      } catch {
    +        case c: ClosedChannelException =>
    --- End diff --
    
    Maybe it should be a `warning`? In this case, the task will fail and it 
hurts nothing to output a warning but will be helpful when we have other issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to