GitHub user zero323 opened a pull request:
https://github.com/apache/spark/pull/17969
[SPARK-20729][SPARKR][ML] Reduce boilerplate in Spark ML models
## What changes were proposed in this pull request?
- Add `JavaModel` and `JavaMLWritable` S4 classes and mix them with
existing ML wrappers.
- Remove individual implementations on `predict` and `write.ml`.
## How was this patch tested?
Unit tests, `check_cran.sh`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zero323/spark SPARK-20729
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17969.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17969
----
commit 8f76158762d74dcf7fa58a9e3f78683a5712e7ad
Author: zero323 <[email protected]>
Date: 2017-05-12T21:49:01Z
Add JavaModel class
commit a77a714f284fe33e425065eed13ae748ef4bf16b
Author: zero323 <[email protected]>
Date: 2017-05-12T22:13:43Z
Remove predict impls from mllib_regression.R
commit 31d60bc422be9b59f37c6ee2b4a2852625d56620
Author: zero323 <[email protected]>
Date: 2017-05-12T22:20:01Z
Remove predict impls from mllib_classification.R
commit 6e7bfdc672140ccee23649273c2d622f7ae78e7d
Author: zero323 <[email protected]>
Date: 2017-05-12T22:22:06Z
Remove predict impls from mllib_clustering.R
commit 95207fdfd6eebbe0374ed6c241b57adb24666d42
Author: zero323 <[email protected]>
Date: 2017-05-12T22:23:32Z
Remove predict impls from mllib_fpm.R
commit 93eefc4e6bc346e50a70a87114f7c51cfe0865b6
Author: zero323 <[email protected]>
Date: 2017-05-12T22:24:29Z
Remove predict impls from mllib_recommendation.R
commit a060dc76473b6cd9dfcf72ba73bd9eb34031b078
Author: zero323 <[email protected]>
Date: 2017-05-12T22:27:15Z
Remove predict impls from mllib_tree.R
commit 7be99929cc3391b075150b65e7daae21c1e97c63
Author: zero323 <[email protected]>
Date: 2017-05-12T22:51:23Z
Add JavaMLWritable
commit 322be5d511b01cf6dc4516a7799e945391db5c47
Author: zero323 <[email protected]>
Date: 2017-05-12T22:55:42Z
Remove write.ml impls from mllib_tree.R
commit 7e16a53a671380fd79c2b4e50ac0c78c4aa8b390
Author: zero323 <[email protected]>
Date: 2017-05-12T22:56:38Z
Remove write.ml impls from mllib_recommendation.R
commit dfbf2f94675114269a37991a83ece2c9644b546c
Author: zero323 <[email protected]>
Date: 2017-05-12T22:57:59Z
Remove write.ml impls from mllib_regression.R
commit 58ef13061d58caaba91b23221763418d78c918f6
Author: zero323 <[email protected]>
Date: 2017-05-12T22:59:50Z
Remove write.ml impls from mllib_classification.R
commit 50056a79cc25ae951ac788769680fa016f471406
Author: zero323 <[email protected]>
Date: 2017-05-12T23:01:01Z
Remove write.ml impls from mllib_clustering.R
commit 0f67137d7f1976d4e497964542bbe1f97d30401e
Author: zero323 <[email protected]>
Date: 2017-05-12T23:02:09Z
Remove write.ml impls from mllib_fpm.R
commit b29d0e21bca5cc12bb604dae4a60be93879bbf9c
Author: zero323 <[email protected]>
Date: 2017-05-12T23:02:49Z
Add seealso to write.ml
commit 1759cf7613385e68d43da4646dbcb1e0ef1b4a87
Author: zero323 <[email protected]>
Date: 2017-05-12T23:04:49Z
Change rdname to write.ml
commit 72f8bcaabeb9150d5ce209a7f8fab36eefd7e4c3
Author: zero323 <[email protected]>
Date: 2017-05-12T23:06:16Z
Correct since annotation
commit 95ec108ae7664c23d268facec0af1c37c6899ff3
Author: zero323 <[email protected]>
Date: 2017-05-12T23:11:40Z
Remove param annotations from generics
commit d7d9d4960132ccc985423b607357d7e56b6f5375
Author: zero323 <[email protected]>
Date: 2017-05-12T23:16:38Z
Annotate object in mllib_tree.R
commit 42c372d62b4c33b778f2ccdde030faea300e5159
Author: zero323 <[email protected]>
Date: 2017-05-12T23:34:42Z
Add ... annotation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
