Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r116657546
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -461,68 +462,249 @@ case class FindInSet(left: Expression, right:
Expression) extends BinaryExpressi
}
/**
- * A function that trim the spaces from both ends for the specified string.
+ * A function that trim the spaces or a trim string from both ends for the
specified string.
*/
@ExpressionDescription(
- usage = "_FUNC_(str) - Removes the leading and trailing space characters
from `str`.",
+ usage = """
+ _FUNC_(str) - Removes the leading and trailing space characters from
`str`.
+ _FUNC_(BOTH trimString FROM str) - Remove the leading and trailing
trimString from `str`
+ _FUNC_(LEADING trimChar FROM str) - Remove the leading trimString from
`str`
+ _FUNC_(TRAILING trimChar FROM str) - Remove the trailing trimString
from `str`
+ """,
extended = """
+ Arguments:
+ str - a string expression
+ trimString - the trim string
+ BOTH, FROM - these are keyword to specify for trim string from both
side of the string
+ LEADING, FROM - these are keyword to specify for trim string from
left side of the string
+ TRAILING, FROM - these are keyword to specify for trim string from
right side of the string
Examples:
> SELECT _FUNC_(' SparkSQL ');
SparkSQL
+ > SELECT _FUNC_(BOTH 'SL' FROM 'SSparkSQLS');
--- End diff --
Hello Zhenhua: Thanks for reviewing the code. As Xiao mentioned in his
previous update
> gatorsmile 14 days ago Member
Oracle:
https://docs.oracle.com/cd/B19306_01/server.102/b14200/functions083.htm
Postgres: https://www.postgresql.org/docs/9.1/static/functions-string.html
It looks like the new version of Oracle and DB2 support the multiple
characters now. I have updated the pr description link.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
