Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r116800916
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1091,6 +1094,23 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
}
/**
+ * Create a name LTRIM for TRIM(Leading), RTRIM for TRIM(Trailing), TRIM
for TRIM(BOTH)
+ */
+ private def visitTrimFuncName(ctx: FunctionCallContext, opt: Token):
String = {
+ if (ctx.qualifiedName.getText.toLowerCase != "trim") {
+ throw new ParseException(s"The specified function
${ctx.qualifiedName.getText} " +
+ s"doesn't support with option ${opt.getText}.", ctx)
+ }
+ opt.getType match {
+ case SqlBaseParser.BOTH => "trim"
+ case SqlBaseParser.LEADING => "ltrim"
+ case SqlBaseParser.TRAILING => "rtrim"
+ case _ => throw new ParseException(s"Function trim doesn't support "
+
+ s"this ${opt.getType}.", ctx)
--- End diff --
thanks, will change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]