Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2516#discussion_r17998809
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
    @@ -48,8 +50,10 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable 
with Logging {
       private[spark] val settings = new HashMap[String, String]()
     
       if (loadDefaults) {
    +    val sparkConfigs = 
SparkSubmitArguments.mergeSparkProperties(Vector.empty)
    --- End diff --
    
    It feels really weird for SparkConf to be calling into 
SparkSubmitArguments, but I haven't read through the rest of the code yet.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to