Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18000292
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -171,19 +179,20 @@ object SparkSubmit {
// All cluster managers
OptionAssigner(args.master, ALL_CLUSTER_MGRS, ALL_DEPLOY_MODES,
sysProp = "spark.master"),
- OptionAssigner(args.name, ALL_CLUSTER_MGRS, ALL_DEPLOY_MODES,
sysProp = "spark.app.name"),
- OptionAssigner(args.jars, ALL_CLUSTER_MGRS, CLIENT, sysProp =
"spark.jars"),
+ OptionAssigner(args.name.orNull, ALL_CLUSTER_MGRS, ALL_DEPLOY_MODES,
--- End diff --
Again with reformatting... please refrain from making these kinds of
changes. They make the patch noisy and hard to review. Also, the current format
follows the existing code standard (otherwise they'd fail to pass the code
checks performed during the build), so there's no point in changing these
unless you're actually changing the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
