Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18031#discussion_r117385321
--- Diff: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala ---
@@ -121,48 +126,69 @@ private[spark] class CompressedMapStatus(
}
/**
- * A [[MapStatus]] implementation that only stores the average size of
non-empty blocks,
- * plus a bitmap for tracking which blocks are empty.
+ * A [[MapStatus]] implementation that stores the accurate size of huge
blocks, which are larger
+ * than both [[config.SHUFFLE_ACCURATE_BLOCK_THRESHOLD]] and
+ * [[config.SHUFFLE_ACCURATE_BLOCK_THRESHOLD_BY_TIMES_AVERAGE]] *
averageSize. It stores the
--- End diff --
It looks the documentation generation for Javadoc 8 is being failed due to
these links -
```
[error]
/home/jenkins/workspace/SparkPullRequestBuilder@2/core/target/java/org/apache/spark/scheduler/HighlyCompressedMapStatus.java:4:
error: reference not found
[error] * than both {@link config.SHUFFLE_ACCURATE_BLOCK_THRESHOLD} and
[error] ^
[error]
/home/jenkins/workspace/SparkPullRequestBuilder@2/core/target/java/org/apache/spark/scheduler/HighlyCompressedMapStatus.java:5:
error: reference not found
[error] * {@link config.SHUFFLE_ACCURATE_BLOCK_THRESHOLD_BY_TIMES_AVERAGE}
* averageSize. It stores the
[error] ^
[error]
/home/jenkins/workspace/SparkPullRequestBuilder/sql/core/target/java/org/apache/spark/sql/functions.java:2996:
error: invalid uri:
"http://docs.oracle.com/javase/tutorial/i18n/format/simpleDateFormat.html
Customizing Formats"
[error] * @see <a
href="http://docs.oracle.com/javase/tutorial/i18n/format/simpleDateFormat.html
Customizing Formats"/>
[error]
^
```
Probably, we should wrap it `` `...` `` as I did before -
https://github.com/apache/spark/pull/16013 or find a way to make this link
properly.
The other errors seem spurious. Please refer my observation -
https://github.com/apache/spark/pull/17389#issuecomment-288438704
(I think we should fix it or document ^ somewhere at least).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
